Added unitless unit and fixed data not plottable for eccentricity jobs #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried it with weights "equal" and "atomic_weight", but it was not quite right. I will try for other trajectories and see if there is a difference, but there will definitely be some cases where it does not work. |
|
OK, I know what happened: while you defined a 'unitless' unit in the json file, on my computer I already have my own modified unit database. MDANSE checks that the user-level unit database exists, and uses it. It does not check if new units appeared in the main database, and if they should be copied into the user database. New users will not be affected by this problem, but if we add new units in the future, then the existing users may miss out on it, unless we add a mechanism for synchronising the databases. |
MBartkowiakSTFC
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Added unitless unit and fixed data not plottable for eccentricity jobs
Fixes
Fixes #363
To test
Run the eccentricity job and load up plot. All results should be plottable.